catalystneuro / ndx-patterned-ogen

patterned (holographic) optogenetic extension to NWB standard
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Generalize light source #13

Closed CodyCBakerPhD closed 2 months ago

CodyCBakerPhD commented 3 months ago

Rename stimulation_wavelength_in_nm to excitation_wavelength_in_nm to be cross-compatible with ndx-microscopy

Also rearranged the order of definitions and generalized some docs

@alessandratrapani Would you know where else to propagate this change throughout this repo?

CodyCBakerPhD commented 3 months ago

Basically, I want to use the LightSource as metadata for ndx-microscopy, but they use the same laser for stimulating and excitation for fluorescence

alessandratrapani commented 3 months ago

Basically, I want to use the LightSource as metadata for ndx-microscopy, but they use the same laser for stimulating and excitation for fluorescence

Maybe the devices in ndx-fiber-photometry are the one we should use.

CodyCBakerPhD commented 3 months ago

Maybe the devices in ndx-fiber-photometry are the one we should use.

In both places?

alessandratrapani commented 3 months ago

In both places?

Yes, it's really time to do an extension for all the ophys devices, so we can import directly from that. I will give this the highest priority and do it by tomorrow.