[Bug]: change all the uses of channel_name now that spikeinterface > 0.101.0 is released

catalystneuro / neuroconv

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.

https://neuroconv.readthedocs.io

BSD 3-Clause "New" or "Revised" License

51 stars 22 forks source link

[Bug]: change all the uses of channel_name now that spikeinterface > 0.101.0 is released #1004

Open tabedzki opened 2 months ago

tabedzki commented 2 months ago

What happened?

baserecordingextractorinterface.py has the following TODO remove this and go and change all the uses of channel_name once spikeinterface > 0.101.0 is released

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

h-mayorquin commented 2 months ago

Yeah, that if becomes unecessary after the latest release. Do you have any downstream problem that derives for this or just contributing to our code cleanliness : )? (thanks btw! just asking in case there is something urgen to fix here)

tabedzki commented 2 months ago

Nothing urgent on my end regarding this. I was exploring the code base to figure out how to implement the other issue about specific SpikeInterface extractor for NIDQ and came across this.

h-mayorquin commented 2 months ago

Thanks for opening an issue.