Closed h-mayorquin closed 2 months ago
@CodyCBakerPhD OK, we got the point were the failures are actually related to zarr, check out the video test failure:
https://github.com/catalystneuro/neuroconv/actions/runs/10744684959/job/29802201096?pr=1056
Does it ring any bell? I will dig into it but is a windows only error so it will have to wait a bit for me.
Note for myself to also add the documentation:
Don't believe I've seen this one myself, but from the message the path to the Zarr array (file): https://github.com/catalystneuro/neuroconv/actions/runs/10744684959/job/29802201096?pr=1056#step:31:3426
is not a valid Windows path (should have replaced the /
with \\
?)
@CodyCBakerPhD OK, this should be ready but it requires the fix on #1070 before (as does everything else).
The cause of the Windows error is here:
@CodyCBakerPhD this is ready to go.
Coolio
Attention: Patch coverage is 97.67442%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 90.40%. Comparing base (
81a022d
) to head (8590f2f
). Report is 14 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...c/neuroconv/tools/testing/data_interface_mixins.py | 97.67% | 1 Missing :warning: |
This enables zarr testing for running conversions with backend specified as a string (still missing the building a backend configuration part)
It also makes some metadata checks proper tests on their own which has two advantages: