search

catalystneuro / neuroconv

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://neuroconv.readthedocs.io
BSD 3-Clause "New" or "Revised" License
51 stars 23 forks source link

Enable testing arm64 Mac architecture in the CI. #1061

Closed h-mayorquin closed 2 months ago

h-mayorquin commented 2 months ago

As in the title. Shoul fix #1054

Let's get the ball rolling on this.

h-mayorquin commented 2 months ago

OK, this is working, we need somehow to skip the doc test for DeepLabCut with M1s and python=3.9. On the other hand, if we follow the numpy convention we should stop supporting python 3.9 now so maybe we don't need to do that.

pauladkisson commented 2 months ago

But this also has the support for the intel mac which I think was only discontinued from pros two years ago or something? To be honest, I would prefer to test only on latest mac, the CI is already super bloated on my view but I think there might be a case here for the two.

How do you feel about it?

I am still using an intel mac, so I would like the tests to include it. Plus, I think they're still relatively common. I agree that the CI is a bit bloated and takes too long to pick up new jobs, but I don't think this is the place to make cuts.

h-mayorquin commented 2 months ago

but I don't think this is the place to make cuts.

This make sense.

Let's brainstorm how to improve the CI at some point.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.43%. Comparing base (ad9f25d) to head (e4461c2). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061/graphs/tree.svg?width=650&height=150&src=pr&token=h63OQoWehP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #1061 +/- ## ======================================= Coverage 90.43% 90.43% ======================================= Files 129 129 Lines 8052 8053 +1 ======================================= + Hits 7282 7283 +1 Misses 770 770 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `90.43% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [...v/datainterfaces/behavior/deeplabcut/\_dlc\_utils.py](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1061?src=pr&el=tree&filepath=src%2Fneuroconv%2Fdatainterfaces%2Fbehavior%2Fdeeplabcut%2F_dlc_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL25ldXJvY29udi9kYXRhaW50ZXJmYWNlcy9iZWhhdmlvci9kZWVwbGFiY3V0L19kbGNfdXRpbHMucHk=) | `55.42% <100.00%> (+0.27%)` | :arrow_up: |