search

catalystneuro / neuroconv

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://neuroconv.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 21 forks source link

Make `get_extractor` work with `MockImagingInterface` #1076

Closed h-mayorquin closed 2 weeks ago

h-mayorquin commented 2 weeks ago

These changes are necessary so the get_extractor method works with MockImagingInterface

https://github.com/catalystneuro/neuroconv/blob/9a886587aece41b3be0c5951b2d6ed54ece83304/src/neuroconv/baseextractorinterface.py#L21-L31

h-mayorquin commented 2 weeks ago

Added changelog.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.36%. Comparing base (81a022d) to head (ca374cb). Report is 10 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076/graphs/tree.svg?width=650&height=150&src=pr&token=h63OQoWehP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #1076 +/- ## ========================================== + Coverage 90.32% 90.36% +0.04% ========================================== Files 129 129 Lines 7996 7999 +3 ========================================== + Hits 7222 7228 +6 + Misses 774 771 -3 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `90.36% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [src/neuroconv/tools/testing/mock\_interfaces.py](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076?src=pr&el=tree&filepath=src%2Fneuroconv%2Ftools%2Ftesting%2Fmock_interfaces.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL25ldXJvY29udi90b29scy90ZXN0aW5nL21vY2tfaW50ZXJmYWNlcy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1076/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)