catalystneuro / neuroconv

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://neuroconv.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 21 forks source link

Only run changelog request when status is not draft #1078

Closed h-mayorquin closed 2 weeks ago

h-mayorquin commented 2 weeks ago

As in the title.

@pauladkisson Here the idea is that the changelog check is only enforced when someone marks the PR as ready for review and from then onwards. This achieves the following which I find desirable:

h-mayorquin commented 2 weeks ago

OK, tests successfully skipped on draft:

image

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.40%. Comparing base (96c8ed4) to head (6f82350). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1078/graphs/tree.svg?width=650&height=150&src=pr&token=h63OQoWehP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1078?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #1078 +/- ## ======================================= Coverage 90.40% 90.40% ======================================= Files 129 129 Lines 8029 8029 ======================================= Hits 7259 7259 Misses 770 770 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1078/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/neuroconv/pull/1078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `90.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more.