search

catalystneuro / neuroconv

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://neuroconv.readthedocs.io
BSD 3-Clause "New" or "Revised" License
51 stars 21 forks source link

[Bug]: Conflict in configure_backend function when using ndx-events 0.3.0 and other extesion #908

Open alessandratrapani opened 4 months ago

alessandratrapani commented 4 months ago

What happened?

Conflict in configure_backend function when using ndx-events 0.3.0 and other extension, e.g ndx-facemap-motion. The neurodata objects in ndx-facemap-motion are not either Data or TimeSeries, thus it will enter the following if condition: https://github.com/catalystneuro/neuroconv/blob/5a65e7417d90411bca3dce8312f8d6d483d30b05/src/neuroconv/tools/nwb_helpers/_configure_backend.py#L56-L59 However, when using ndx-events 0.3.0 this will cause an error since ndx_events.Events it's compatible only with ndx-events 0.2.0

trace back error

Screenshot from 2024-06-13 10-45-32

Operating System

Linux

Python Executable

Conda

Python Version

3.8

Package Versions

No response

Code of Conduct

pauladkisson commented 4 months ago

Could probably add a check for ndx_events_is_version_0_2_0 and then only check ndx_events.Events if it's the right version?

alessandratrapani commented 4 months ago

add check for ndx_event version

CodyCBakerPhD commented 4 months ago

Is ndx-events==0.3.0 released?

h-mayorquin commented 2 months ago

It does not seem it is:

https://pypi.org/project/ndx-events/#history