catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Synchronize with latest changes in roiextractors #555

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

This PR makes the code compliant with the latest changes in roiextractors. See:

https://github.com/catalystneuro/roiextractors/pull/166

The changes include the modification of the hdf5 imaging extractor, the elimination of channels in the TiffExtractors and the change of variable names in the dummy imaging extractors. Also, using folder_path in Suite2P.

codecov[bot] commented 2 years ago

Codecov Report

Merging #555 (9f7d779) into main (2d2a045) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   88.21%   88.25%   +0.03%     
==========================================
  Files          59       59              
  Lines        3166     3168       +2     
==========================================
+ Hits         2793     2796       +3     
+ Misses        373      372       -1     
Flag Coverage Δ
unittests 88.25% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aces/ecephys/neuroscope/neuroscopedatainterface.py 76.03% <100.00%> (+0.40%) :arrow_up:
...faces/ophys/scanimage/scanimageimaginginterface.py 88.46% <100.00%> (ø)
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 100.00% <100.00%> (ø)
...ols/datainterfaces/ophys/tiff/tiffdatainterface.py 100.00% <100.00%> (ø)
...version_tools/tools/roiextractors/roiextractors.py 80.00% <0.00%> (+0.40%) :arrow_up:
h-mayorquin commented 2 years ago

@CodyCBakerPhD Thanks for changing the commit hash.