Closed h-mayorquin closed 2 years ago
It seems that the errors are the ones in catalystneuro/nwb-conversion-tools#560
@h-mayorquin Can you add tests for all this alongside https://github.com/catalystneuro/nwb-conversion-tools/tree/refactor_intan/tests/test_on_data/test_metadata?
@h-mayorquin Can you add tests for all this alongside https://github.com/catalystneuro/nwb-conversion-tools/tree/refactor_intan/tests/test_on_data/test_metadata?
I want to this in a separate PR. Recently there has been some effort into propagating the metadata for neo to spikeinterface (https://github.com/SpikeInterface/spikeinterface/pull/627). I want to see what's available to add metadata to each of the interfaces and then test based on that structure.
Merging #558 (c239f61) into main (85fcdf6) will increase coverage by
0.19%
. The diff coverage is100.00%
.:exclamation: Current head c239f61 differs from pull request most recent head 0749e43. Consider uploading reports for the commit 0749e43 to get more accurate results
@@ Coverage Diff @@
## main catalystneuro/nwb-conversion-tools#558 +/- ##
==========================================
+ Coverage 88.11% 88.30% +0.19%
==========================================
Files 59 59
Lines 3138 3147 +9
==========================================
+ Hits 2765 2779 +14
+ Misses 373 368 -5
Flag | Coverage Δ | |
---|---|---|
unittests | 88.30% <100.00%> (+0.19%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...datainterfaces/ecephys/intan/intandatainterface.py | 96.42% <100.00%> (+0.68%) |
:arrow_up: |
...ion_specification/yaml_conversion_specification.py | 94.93% <0.00%> (+6.32%) |
:arrow_up: |
This is in the context of catalystneuro/neuroconv#60 This PR refactors the code if the
IntanRecordingInterface
in preparation for adding support forspikeinteface
. The biggest change is that it uses anOldToNewRecording
so all the properties are now set in the manner of the newspikeinterface
API.