catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.

https://nwb-conversion-tools.readthedocs.io/en/main/

BSD 3-Clause "New" or "Revised" License

25 stars 12 forks source link

Make imaging extrator interface an abstract class #559

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

Should fix #557

h-mayorquin commented 2 years ago

It seems that the errors are the ones in #560.

CodyCBakerPhD commented 2 years ago

It seems that the errors are the ones in https://github.com/catalystneuro/nwb-conversion-tools/pull/560.

Yup, it's affecting everything ATM. Trying to get a fix out. Problem is they changed the SpikeGLX files on GIN to make them shorter, but made a header/file mismatch in the process.

h-mayorquin commented 2 years ago

@CodyCBakerPhD Any idea on this error? https://github.com/catalystneuro/nwb-conversion-tools/runs/7102719467?check_suite_focus=true

This is related to the newly cli-yaml test.

codecov[bot] commented 2 years ago

Codecov Report

Merging #559 (b5506a0) into main (7baf94a) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          59       59           
  Lines        3135     3135           
=======================================
  Hits         2769     2769           
  Misses        366      366

Flag	Coverage Δ
unittests	`88.32% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ainterfaces/ophys/baseimagingextractorinterface.py	`95.34% <100.00%> (ø)`

CodyCBakerPhD commented 2 years ago

Any idea on this error? https://github.com/catalystneuro/nwb-conversion-tools/runs/7102719467?check_suite_focus=true

This is related to the newly cli-yaml test.

Not sure, I might have seen that before. But the fact that rerunning fixed it is strange indeed.