search

catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Added docstring and refactor metadata to `IntanRecordingInterface` #562

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

Added docstring to intan and some refactoring of theget_metadat function. This should be done after #561.

CodyCBakerPhD commented 2 years ago

@h-mayorquin So this just needs metadata tests now for the Intan interface, right?

h-mayorquin commented 2 years ago

@h-mayorquin So this just needs metadata tests now for the Intan interface, right?

Yes. Along with most of the interfaces.

codecov[bot] commented 2 years ago

Codecov Report

Merging #562 (e928447) into main (2d2a045) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   88.21%   88.24%   +0.02%     
==========================================
  Files          59       59              
  Lines        3166     3173       +7     
==========================================
+ Hits         2793     2800       +7     
  Misses        373      373
Flag Coverage Δ
unittests 88.24% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...datainterfaces/ecephys/intan/intandatainterface.py 97.40% <100.00%> (+0.18%) :arrow_up:
...aces/ecephys/neuroscope/neuroscopedatainterface.py 76.03% <100.00%> (+0.40%) :arrow_up: