catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Add spikeinterface support for `SpikeGadgetsRecordingInterface` #573

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

As stated in the title. Linked to https://github.com/catalystneuro/neuroconv/issues/60.

h-mayorquin commented 2 years ago

There is a problem with the doctest as spikeinterface is producing output to standard output. See: https://github.com/SpikeInterface/spikeinterface/pull/758

codecov[bot] commented 2 years ago

Codecov Report

Merging #573 (5f5c1a3) into main (e928447) will increase coverage by 0.04%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     catalystneuro/nwb-conversion-tools#573      +/-   ##
==========================================
+ Coverage   88.24%   88.29%   +0.04%     
==========================================
  Files          59       59              
  Lines        3173     3177       +4     
==========================================
+ Hits         2800     2805       +5     
+ Misses        373      372       -1     
Flag Coverage Δ
unittests 88.29% <92.85%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ecephys/spikegadgets/spikegadgetsdatainterface.py 95.83% <87.50%> (+0.83%) :arrow_up:
...faces/ophys/scanimage/scanimageimaginginterface.py 88.46% <100.00%> (ø)
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 100.00% <100.00%> (ø)
...ols/datainterfaces/ophys/tiff/tiffdatainterface.py 100.00% <100.00%> (ø)
...version_tools/tools/roiextractors/roiextractors.py 80.00% <0.00%> (+0.40%) :arrow_up: