search

catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Remove optional typing in neuroscope #576

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

Remove the wrong optional typing in Neuroscope.

codecov[bot] commented 2 years ago

Codecov Report

Merging #576 (061ce3d) into main (e928447) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   88.24%   88.27%   +0.03%     
==========================================
  Files          59       59              
  Lines        3173     3173              
==========================================
+ Hits         2800     2801       +1     
+ Misses        373      372       -1
Flag Coverage Δ
unittests 88.27% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aces/ecephys/neuroscope/neuroscopedatainterface.py 76.03% <ø> (ø)
...faces/ophys/scanimage/scanimageimaginginterface.py 88.46% <100.00%> (ø)
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 100.00% <100.00%> (ø)
...ols/datainterfaces/ophys/tiff/tiffdatainterface.py 100.00% <100.00%> (ø)
...version_tools/tools/roiextractors/roiextractors.py 80.00% <0.00%> (+0.40%) :arrow_up: