catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Refactor neuralynx before adding support for spikeinterface #577

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

In the context of https://github.com/catalystneuro/neuroconv/issues/60. This is a refactor to ensure that everything propagates well with the new recording interface. I will chain a PR to this introducing support for spikeinterface.

codecov[bot] commented 2 years ago

Codecov Report

Merging #577 (c37765c) into main (e928447) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     catalystneuro/nwb-conversion-tools#577      +/-   ##
==========================================
+ Coverage   88.24%   88.30%   +0.05%     
==========================================
  Files          59       59              
  Lines        3173     3180       +7     
==========================================
+ Hits         2800     2808       +8     
+ Misses        373      372       -1     
Flag Coverage Δ
unittests 88.30% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rfaces/ecephys/neuralynx/neuralynxdatainterface.py 96.87% <100.00%> (+0.38%) :arrow_up:
...faces/ophys/scanimage/scanimageimaginginterface.py 88.46% <100.00%> (ø)
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 100.00% <100.00%> (ø)
...ols/datainterfaces/ophys/tiff/tiffdatainterface.py 100.00% <100.00%> (ø)
...version_tools/tools/roiextractors/roiextractors.py 80.00% <0.00%> (+0.40%) :arrow_up: