catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Add spikeinterface support and and gin test for `CEDRecordingInterface` #582

Closed h-mayorquin closed 2 years ago

h-mayorquin commented 2 years ago

Add spikeinterface support to CEDRecordingInterface. Part of catalystneuro/neuroconv#60

As discussed with @bendichter today, this did not have an associated gin test with spikeextractors so I am only adding spikeinterface support as it is.

I also had a problem running the old format (.smr) tests in my own system but spikeinterface testing suite indicates that it should be supported. I am adding it here to see if it is a problem of local dependencies exclusive to me. If not, then probably we will have to support only the new format ("smrx") for a while until we figure this out.

h-mayorquin commented 2 years ago

This has the same error than the one in my personal system. It seems that at least temporary we will only be able to support the new format.

CodyCBakerPhD commented 2 years ago

This has the same error than the one in my personal system. It seems that at least temporary we will only be able to support the new format.

Yup, that's fine. We've had trouble with sonpy before (hence the platform/PyVersion tests targeted at that) so it's not too much of a surprise

codecov[bot] commented 2 years ago

Codecov Report

Merging #582 (5413d32) into main (0cfc0d1) will increase coverage by 0.04%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     catalystneuro/nwb-conversion-tools#582      +/-   ##
==========================================
+ Coverage   88.34%   88.39%   +0.04%     
==========================================
  Files          59       59              
  Lines        3192     3196       +4     
==========================================
+ Hits         2820     2825       +5     
+ Misses        372      371       -1     
Flag Coverage Δ
unittests 88.39% <87.50%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/datainterfaces/ecephys/ced/ceddatainterface.py 79.41% <87.50%> (+6.07%) :arrow_up: