search

catalystneuro / nwb-conversion-tools

Create NWB files by converting and combining neural data in proprietary formats and adding essential metadata.
https://nwb-conversion-tools.readthedocs.io/en/main/
BSD 3-Clause "New" or "Revised" License
25 stars 12 forks source link

Bump PyNWB version #592

Closed CodyCBakerPhD closed 2 years ago

CodyCBakerPhD commented 2 years ago

PyNWB just released a new version; bumping it in full requirements and testing here

bendichter commented 2 years ago

Now pynwb allows you to not write x,y,z,location, and imp. If we want to use that feature we will need to bump the minimum version too.

CodyCBakerPhD commented 2 years ago

Now pynwb allows you to not write x,y,z,location, and imp. If we want to use that feature we will need to bump the minimum version too.

Good to remember that - we can discuss at next team meeting if we want to require the Conversion Tools to use minimally only the most recent versions of everything.

For now, we've technically always treated those as optional internally; if the recording object has that info, we write it, otherwise set them to NaN ourselves. Raised reminder issue here: https://github.com/catalystneuro/neuroconv/issues/6