catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

`SegmentationExtractor`: add `set_times` #188

Closed weiglszonja closed 2 years ago

weiglszonja commented 2 years ago

Follow up on #187

Adds set_times method to SegmentationExtractor. The use case is to be able to write segmentation data with timestamps.

CodyCBakerPhD commented 2 years ago

@weiglszonja Ready for review?

weiglszonja commented 2 years ago

@CodyCBakerPhD yes, let me know if there are other tests that should be added

codecov[bot] commented 2 years ago

Codecov Report

Merging #188 (eaf79a4) into master (6233dca) will decrease coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   73.13%   73.02%   -0.11%     
==========================================
  Files          33       33              
  Lines        2196     2169      -27     
==========================================
- Hits         1606     1584      -22     
+ Misses        590      585       -5     
Flag Coverage Δ
unittests 73.02% <100.00%> (-0.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...schnitzerextractor/extractsegmentationextractor.py 94.32% <ø> (+1.34%) :arrow_up:
src/roiextractors/segmentationextractor.py 87.87% <100.00%> (+1.42%) :arrow_up: