catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

Rename `MicroManagerTiffImagingExtractor` channel to 'OpticalChannelDefault' #223

Closed weiglszonja closed 1 year ago

weiglszonja commented 1 year ago

Micro-Manager uses "Default" as channel name, it is better to rename it to 'OpticalChannelDefault' for clarity

codecov[bot] commented 1 year ago

Codecov Report

Merging #223 (475d6bc) into main (ae5f252) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   75.45%   75.46%           
=======================================
  Files          35       35           
  Lines        2514     2515    +1     
=======================================
+ Hits         1897     1898    +1     
  Misses        617      617           
Flag Coverage Δ
unittests 75.46% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gingextractors/micromanagertiffimagingextractor.py 99.15% <100.00%> (+<0.01%) :arrow_up:
CodyCBakerPhD commented 1 year ago

I meant that you can modify it at the extractor level within the interface; the notion of the OpticChannel is NWB specific and the notion of the naming scheme is also NWB specific, so IDK that ROIExtractors would need to adopt it directly

weiglszonja commented 1 year ago

@CodyCBakerPhD I misunderstood it, let's do it that way.