catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

Add `depth_slice()` to ImagingExtractors #231

Closed weiglszonja closed 7 months ago

weiglszonja commented 1 year ago

Add support for slicing over planes for volumetric imaging data. (first example for volumetric imaging: https://github.com/catalystneuro/roiextractors/pull/230) WIP

pauladkisson commented 1 year ago

This logic should be moved to volumetricimagingextractor.py once #248 is merged.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.71%. Comparing base (c5dedb2) to head (1da7855). Report is 15 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231/graphs/tree.svg?width=650&height=150&src=pr&token=UA958XVSZP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== + Coverage 79.17% 79.71% +0.54% ========================================== Files 39 39 Lines 3054 3141 +87 ========================================== + Hits 2418 2504 +86 - Misses 636 637 +1 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `79.71% <94.44%> (+0.54%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [...tors/extractors/numpyextractors/numpyextractors.py](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL3JvaWV4dHJhY3RvcnMvZXh0cmFjdG9ycy9udW1weWV4dHJhY3RvcnMvbnVtcHlleHRyYWN0b3JzLnB5) | `65.32% <95.83%> (+4.37%)` | :arrow_up: | | [src/roiextractors/testing.py](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL3JvaWV4dHJhY3RvcnMvdGVzdGluZy5weQ==) | `98.73% <87.50%> (-0.59%)` | :arrow_down: | | [src/roiextractors/imagingextractor.py](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL3JvaWV4dHJhY3RvcnMvaW1hZ2luZ2V4dHJhY3Rvci5weQ==) | `85.29% <95.00%> (+4.04%)` | :arrow_up: |
pauladkisson commented 8 months ago

@weiglszonja, are you still working on this?

weiglszonja commented 7 months ago

hey @pauladkisson, not actively. do you want to close this for now?

pauladkisson commented 7 months ago

Yeah, since a lot of this needs to be revamped for volumetric imaging extractor, I think we can close this PR and circle back around to it when we have a concrete reason to do so.