search

catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Fix `MicroManagerTiffImagingExtractor` private extractor's `dtype` #257

Closed weiglszonja closed 10 months ago

weiglszonja commented 10 months ago

Fixes that the private extractors dtype should match the main extractor's dtype, and adds test to make sure not overriding it in private extractor's get_video()

codecov[bot] commented 10 months ago

Codecov Report

Merging #257 (3d6104d) into main (8041fb0) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   79.00%   79.01%   +0.01%     
==========================================
  Files          39       39              
  Lines        3029     3031       +2     
==========================================
+ Hits         2393     2395       +2     
  Misses        636      636
Flag Coverage Δ
unittests 79.01% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gingextractors/micromanagertiffimagingextractor.py 98.33% <100.00%> (+0.02%) :arrow_up: