search

catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Fix override of `channel_name` in `Suite2pSegmentationExtractor` #263

Closed weiglszonja closed 9 months ago

weiglszonja commented 10 months ago

Fix an oversight from my side in #242 which overrides channel_name and leads to incorrect reading of the mean image.

CodyCBakerPhD commented 10 months ago

@weiglszonja Can you think of any way to add a test for this?

codecov[bot] commented 9 months ago

Codecov Report

Merging #263 (3ca299f) into main (abe24d7) will decrease coverage by 0.01%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263/graphs/tree.svg?width=650&height=150&src=pr&token=UA958XVSZP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro)](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) ```diff @@ Coverage Diff @@ ## main #263 +/- ## ========================================== - Coverage 79.01% 79.00% -0.01% ========================================== Files 39 39 Lines 3031 3030 -1 ========================================== - Hits 2395 2394 -1 Misses 636 636 ``` | [Flag](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | `79.00% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro) | Coverage Δ | | |---|---|---| | [...extractors/suite2p/suite2psegmentationextractor.py](https://app.codecov.io/gh/catalystneuro/roiextractors/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=catalystneuro#diff-c3JjL3JvaWV4dHJhY3RvcnMvZXh0cmFjdG9ycy9zdWl0ZTJwL3N1aXRlMnBzZWdtZW50YXRpb25leHRyYWN0b3IucHk=) | `89.54% <100.00%> (-0.07%)` | :arrow_down: |