catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Fix Update Dev Version on Release Workflow #304

Closed pauladkisson closed 4 months ago

pauladkisson commented 5 months ago

The triggering workflow name for update version was incorrectly set to auto-publish (the name of the yaml file). It should have been Upload Package to PyPI (the name field of the workflow).

No easy way to retrigger the upload package to pypi workflow -- in fact using skip-existing is specifically recommended against by action authors: https://github.com/pypa/gh-action-pypi-publish. So, we'll just have to check if this works properly on the next release.

Also, the triggered PR doesn't run the appropriate tests bc of a github actions bug with the secrets.GITHUB_TOKEN (see stack overflow) --> so that is fixed by using my PAT -- see #308