search

catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Update Workflows #317

Closed pauladkisson closed 4 months ago

pauladkisson commented 4 months ago
pauladkisson commented 4 months ago

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

CodyCBakerPhD commented 4 months ago

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

Can you ping them about that?

Also you can just add a skip for that on relevant tests, platform.architecture + platform.platform or sys.platform should give you something to use to distnguish skip logic

pauladkisson commented 4 months ago

Looks like scanimage-tiff-reader doesn't support arm...I guess we wait for them?

Can you ping them about that?

Done: https://gitlab.com/vidriotech/scanimagetiffreader-python/-/issues/31

pauladkisson commented 4 months ago

wait, I'm in the middle of this fix too

CodyCBakerPhD commented 4 months ago

It looks like the codecov upload action could be updated too

Also looks like current actions don't cancel previous runs on new pushes? Can you add that too everywhere, saves a lot of redundant CI time

CodyCBakerPhD commented 4 months ago

@pauladkisson lowercase darwin

I believe platform.system() is upper-case, sys.platform is lower case

You'll just also need a conditional add for https://github.com/catalystneuro/roiextractors/blob/workflow/tests/test_io.py#L48 to the list of IO to test

pauladkisson commented 4 months ago

You'll just also need a conditional add for https://github.com/catalystneuro/roiextractors/blob/workflow/tests/test_io.py#L48 to the list of IO to test

Ah, right, forgot about that one.

CodyCBakerPhD commented 4 months ago

Looks great, thanks!