catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

BaseSegmentation class improvements #327

Closed CodyCBakerPhD closed 4 months ago

CodyCBakerPhD commented 5 months ago

Writing a custom segmentation extractor, noticed a couple of things

i) self._image_mask is used in later methods but never specific in the base __init__; not a huge deal, but figured I'd include it there to at least demonstrate how to include it during file read

ii) moved an abstractmethod towards the top of the class to make it easier to spot (since it needs to be defined in any child)