search

catalystneuro / roiextractors

Python-based module for extracting from, converting between, and handling optical imaging data from several file formats. Inspired by SpikeInterface.
https://roiextractors.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
12 stars 7 forks source link

Removed unnecessary import checks for scipy, h5py, and zarr #364

Closed pauladkisson closed 2 months ago

pauladkisson commented 2 months ago

Fixes #316

As well as h5py and zarr. sima checks are kept bc they are not installed in requirements bc it is gpl.

pauladkisson commented 2 months ago

Have you considered importing at init to speed up importing times. Scipy is sort of heavy-ish...

I haven't noticed install time as a problem, how did it come up for spikeinterface?

h-mayorquin commented 2 months ago

Importing times, not installing times. We have a test for import times in the CI of SI:

https://github.com/SpikeInterface/spikeinterface/pull/2955

pauladkisson commented 2 months ago

Importing times, not installing times. We have a test for import times in the CI of SI:

Interesting, I'll have to look into this, but for now I'm going to keep imports where they are.