search

catamphetamine / country-flag-icons

Vector (*.svg) country flag icons in 3x2 aspect ratio
https://catamphetamine.github.io/country-flag-icons/3x2/
MIT License
107 stars 28 forks source link

Failing build: missing `runnable` folder? #2

Closed mindplay-dk closed 4 years ago

mindplay-dk commented 4 years ago

After cloning and running npm install, I get the following error:

> country-flag-icons@1.0.5 generate-countries /home/mindplay/workspace/country-flag-icons
> babel-node runnable/generate-countries

internal/modules/cjs/loader.js:796
    throw err;
    ^

Error: Cannot find module '/home/mindplay/workspace/country-flag-icons/runnable/generate-countries'

The runnable folder seems to be missing from source-control?

(This project looks fantastic, by the way! Every other flag package has some flags with way too much detail, inconsistent file sizes or dimensions etc. - it must have been quite a bit of work to curate this package... I'd like to contribute another build-script, one that inlines all the SVG images in a single CSS file to avoid the JavaScript overhead of the React component...)

catamphetamine commented 4 years ago

Github website was having status 500 errors and didn't accept comments.

@mindplay-dk Thx, removed runnable from .gitignore.

catamphetamine commented 4 years ago

it must have been quite a bit of work to curate this package...

Not really, initially. But I'll be redrawing most of the flags a little bit.