catamphetamine / libphonenumber-js

A simpler (and smaller) rewrite of Google Android's libphonenumber library in javascript
https://catamphetamine.gitlab.io/libphonenumber-js/
MIT License
2.79k stars 216 forks source link

Meta data Params updates #238

Closed waleedarshad closed 6 years ago

waleedarshad commented 6 years ago

Hi @catamphetamine Please use this merge request to update optional parameters

I had uncommented es6 & metadata.min from my fork .gitignore because it was required in code when i included that into my project.

But this pull request is refined form without es6 and metaData. you can merge this

Thanks

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 67f5418d8fc36bee5eb5426f9e3d901ad57dd4c1 on waleedarshad:meta-data into 162206ca2a0c49616eb0a5b54290952b00514c42 on catamphetamine:master.

catamphetamine commented 6 years ago

The default parseNumber() export doesn't accept metadata. The custom.js ones do.

waleedarshad commented 6 years ago

so for using CustomParseNumber do i have to import like this?

import { parseNumber } from 'libphonenumber-js/custom'

as there is not documentation specified how to use custom methods

catamphetamine commented 6 years ago

There is

waleedarshad commented 6 years ago

Thanks