search

catamphetamine / libphonenumber-js

A simpler (and smaller) rewrite of Google Android's libphonenumber library in javascript
https://catamphetamine.gitlab.io/libphonenumber-js/
MIT License
2.79k stars 216 forks source link

TypeScript: fixed method signature for searchPhoneNumbers #243

Closed brandon-barker closed 6 years ago

brandon-barker commented 6 years ago

This PR fixes the below error caused by an invalid method signature on searchPhoneNumbers in custom.d.ts

ERROR in node_modules/libphonenumber-js/custom.d.ts(35,108): error TS1016: A required parameter cannot follow an optional parameter.

This issue is causing our builds to fail on the latest angular cli

We are working around it by fixing it locally and installing the tarball, but would love it if you could merge this and release an official fix.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 49252e1492b7b806680463ac592466292a17b9b1 on brandon-barker:master into 970c2a0a6d5732b30e96b65a88caa5fa9ad39235 on catamphetamine:master.

catamphetamine commented 6 years ago

More like this: https://github.com/catamphetamine/libphonenumber-js/commit/2f63698dde26a6cd5696ad320ce2de6fdc74e0ba

Released libphonenumber-js@1.4.4.

brandon-barker commented 6 years ago

Thank you!