search

catamphetamine / libphonenumber-js

A simpler (and smaller) rewrite of Google Android's libphonenumber library in javascript
https://catamphetamine.gitlab.io/libphonenumber-js/
MIT License
2.77k stars 217 forks source link

Fix error in typescript types #287

Closed audiolion closed 5 years ago

audiolion commented 5 years ago

The index signature for type Countries cannot be a union type (e.g. "US" | "UK" | ...), we instead convert the syntax to [country in Countries] to satisfy the constraint. See https://github.com/Microsoft/TypeScript/issues/19768 for more info on why this cannot happen.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9ad8428f72dfcad54c1223429b477ac2e1f8c330 on audiolion:patch-1 into 614f17c7d590c2bc25e78a9bf8179a6311ce0ce6 on catamphetamine:master.

catamphetamine commented 5 years ago

Thx, released libphonenumber-js@1.7.5.