catamphetamine / libphonenumber-js

A simpler (and smaller) rewrite of Google Android's libphonenumber library in javascript
https://catamphetamine.gitlab.io/libphonenumber-js/
MIT License
2.79k stars 216 forks source link

French mobile phone starting with 07 are considered as incorrect #314

Closed EikiProg closed 5 years ago

EikiProg commented 5 years ago

Since 3 may 2010, french mobile phone starting with 07 are correct mobile phone number.

https://libphonenumber.appspot.com/phonenumberparser?number=0716693321&country=FR&geocodingLocale=fr-FR

catamphetamine commented 5 years ago

The Google demo says the number is not valid.

EikiProg commented 5 years ago

Yes that the problem, and the number should be valid since 3 may 2010.

catamphetamine commented 5 years ago

You should report it to Google then. This library uses Google's metadata.

EikiProg commented 5 years ago

Well i can't post an issue on https://github.com/googlei18n/libphonenumber, too bad they are 9 year late.

catamphetamine commented 5 years ago

They accept issues via Google Groups or something. Read ther FAQ or README, it was there somewhere.

jdequeant commented 5 years ago

Can you reopen this issue ? Google accepts now mobile phone number starting with 07 (https://libphonenumber.appspot.com/phonenumberparser?number=0780808080&country=FR) but not this library.

catamphetamine commented 5 years ago

Provide the full info: what exactly you think is different between this library demo and google's demo.

jdequeant commented 5 years ago

Sorry, I've tried two different numbers (0780808080 and 0714481221). Indeed, both libraries considers that the first number is valid but not the second one. Sorry for the inconvenience.