search

catamphetamine / react-phone-number-input

React component for international phone number input
http://catamphetamine.gitlab.io/react-phone-number-input/
MIT License
914 stars 194 forks source link

Update <img> tag for accessibility #344

Closed jbrower2 closed 4 years ago

jbrower2 commented 4 years ago

Add role="presentation" and aria-hidden="true" to flag <img\> tag for accessibility.

This is to satisfy Web Content Accessibility Guidelines Success Criterion 1.3.1: Info and Relationships.

catamphetamine commented 4 years ago

@jbrower2 Just role="presentation" is sufficient. https://www.w3.org/TR/2017/WD-wai-aria-practices-1.1-20170628/examples/presentation/PresentationRoleExamples.html Also, don't change the line ending in the end.

catamphetamine commented 4 years ago

@jbrower2 Don't change the line ending in the end.

jbrower2 commented 4 years ago

@catamphetamine Sorry about the line ending. I was editing this in the github UI, and it seems that it automatically adds the line ending whenever I commit. Will check this out on my machine.

catamphetamine commented 4 years ago

@jbrower2 Ah, whatever, I'm merging.

catamphetamine commented 4 years ago

@jbrower2 Published react-phone-number-input@3.0.21. Thx.