search

catamphetamine / react-phone-number-input

React component for international phone number input
http://catamphetamine.gitlab.io/react-phone-number-input/
MIT License
914 stars 194 forks source link

Transfer styles over to StyledComponents #358

Closed enahsor closed 4 years ago

enahsor commented 4 years ago

This is my first attempt at contributing to OS. Can I move the current styles over to using styled components? I think this will improve maintainability.

catamphetamine commented 4 years ago

What do you mean by "move the current styles over to using styled components"

enahsor commented 4 years ago

@catamphetamine thanks for getting back to me. Instead of having the css separated from the components it is styling, I would make use of https://styled-components.com/ to move the styles for each component into the component itself.

catamphetamine commented 4 years ago

@enahsor Aaah, I see. Well, personally, I'm not a fan of "CSS in JS" so I wouldn't merge such pull request, but you can create your own fork and do anything there, the difficult part would be maintaining it on your own though.