search

catamphetamine / react-phone-number-input

React component for international phone number input
http://catamphetamine.gitlab.io/react-phone-number-input/
MIT License
914 stars 193 forks source link

Missing CSS variable `PhoneInputCountrySelectArrow-height` #362

Closed laclance closed 3 years ago

laclance commented 3 years ago

style.css line 9: 

--PhoneInputCountrySelectArrow-marginTop: calc(var(--PhoneInputCountrySelectArrow-height) / 2);

but PhoneInputCountrySelectArrow-height does not exist?

catamphetamine commented 3 years ago

Indeed, it wasn't defined. This is equal to the CSS variable being ignored, so margin-top is actually ignored. I removed the --PhoneInputCountrySelectArrow-marginTop variable from CSS, and the corresponding margin-top rule on the arrow element. There's no need to release a new version with the fix because of how CSS variables work: when a CSS variable is not found, the CSS rule is ignored.