Validation: 11 digit Indian number validates to true

[grahamlutz]

It looks like the validation for Indian numbers continues to validate numbers with between 11-14 numbers. The following screen shot is with a valid Indian number:

The following is with an 11 digit (invalid) Indian phone number, which still has isValid: true

Then the following is the same situation for US numbers. First screenshot is a valid number with 10 digits with isValid: true and the second is an invalid number with 11 digits and isValid: false

[catamphetamine]

What's your exact question?

[grahamlutz]

Shouldn't 11 digit (not including country code) Indian numbers return isValid: false?

[catamphetamine]

I dunno. What does the google demo say.

[catamphetamine]

Oh, I get it, once again, a bug report for another repo. I'm gonna add this to the readme. In a minute.

[catamphetamine]

See the updated readme:

https://github.com/catamphetamine/react-phone-number-input#bug-reporting

[grahamlutz]

It looks like google's result from isValidNumber() is false.

[catamphetamine]

Ok, then the next step would be using the full metadata in the React component

<PhoneInput metadata={require('libphonenumber-js/metadata.full.json')}/>

[grahamlutz]

Got it, Thanks!

[grahamlutz]

So I've got that in place, and it's pulling it in but does't change anything. This is what the props on our phone component looks like:

And this is what I am using to validate:

handleBlur = (e) => {
    let phone = e.target.value;

    if (!isValidPhoneNumber(phone) && phone != "") {
      this.setState({isValid: false});
    }
    else {
      this.setState({isValid: true});
    }
};

Any other thoughts?

[catamphetamine]

Oh, man, I mislead you a bit on this one. Actually, use 'isValidNumberCustom' with the full metadata as described in 'libphonenumber-js' readme.

On Wed, 6 Sep 2017 at 21:44, Graham Lutz notifications@github.com wrote:

So I've got that in place, and it's pulling it in but does't change anything. This is what the props on our phone component looks like:

[image: screen shot 2017-09-06 at 2 42 09 pm] https://user-images.githubusercontent.com/12991947/30128748-c6b7fd82-9311-11e7-96c5-db073d214c2c.png

And this is what I am using to validate:

handleBlur = (e) => { let phone = e.target.value;

if (!isValidPhoneNumber(phone) && phone != "") {
  this.setState({isValid: false});
}
else {
  this.setState({isValid: true});
}

};

Any other thoughts?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/catamphetamine/react-phone-number-input/issues/70#issuecomment-327577523, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdH7yTnoBEFBp65ad0bj6P6YV1keyQAks5sfugYgaJpZM4POruA .