search

catamphetamine / webpack-isomorphic-tools

Server-side rendering for your Webpack-built applications (e.g. React)
MIT License
1.25k stars 48 forks source link

Depreciation for webpack 4x #156

Closed tavurth closed 6 years ago

tavurth commented 6 years ago 
(node:6433) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
    at Webpack_isomorphic_tools_plugin.apply (/home/william/projects/frontend/node_modules/webpack-isomorphic-tools/source/plugin/plugin.js:152:11)
    at webpack (/home/william/projects/frontend/node_modules/webpack/lib/webpack.js:37:12)
    at Object.<anonymous> (/home/william/projects/frontend/server/webpack/server.dev.js:9:25)
    at Module._compile (module.js:652:30)
    at loader (/home/william/projects/frontend/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/william/projects/frontend/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
catamphetamine commented 6 years ago

Seems that the next major webpack version (version 5.0.0) is gonna break webpack-isomorphic-tools plugin. If you're upgrading webpack then you should think about replacing webpack-isomorphic-tools perhaps with universal-webpack. Otherwise someone could migrate the plugin to support the new way of writing plugins in v4 (and send a pull request).

tavurth commented 6 years ago

@catamphetamine We've been looking to move away from webpack-isomorphic-tools in any case, so this will provide a good incentive. Thank you for the advice!