Upgrade for webpack 4 - Githubissues

catamphetamine / webpack-isomorphic-tools

Server-side rendering for your Webpack-built applications (e.g. React)

MIT License

1.25k stars 48 forks source link

Upgrade for webpack 4 #159

Closed lemonCMS closed 6 years ago

lemonCMS commented 6 years ago

This pull request uses the new .hooks api.

I must say this.hooks api needs a extra parameter options. and within options the name attribute must be present. Right now i pass the plugin.options object, but i truly do not know if this is correct or overkill.

Does anyone have a idea?

coveralls commented 6 years ago

Coverage increased (+0.2%) to 84.137% when pulling 346c173f24f638faac225bfe5498ccc8cda3b962 on lemonCMS:master into 04892a4ed81c3bb4cae85042554018fb97b9a1e4 on catamphetamine:master.

catamphetamine commented 6 years ago

@lemonCMS Oh, indeed, time has come to upgrade this one. I'll make the changes based on your code and release a new version today. Thanks for the PR, I'm closing it.

catamphetamine commented 6 years ago

Closed in https://github.com/catamphetamine/webpack-isomorphic-tools/issues/156

catamphetamine commented 6 years ago

@lemonCMS Try version 3.0.6 and see if it works. I don't have a project for testing new versions now.

lemonCMS commented 6 years ago

Thx, it seems to be working!