search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 562 forks source link

PostTask flow IDs are not unique or do not have matching "s" and "f" phase #1161

Closed catapult-bot closed 9 years ago

catapult-bot commented 9 years ago

Issue by yuhao Friday Jul 31, 2015 at 00:03 GMT Originally opened as https://github.com/google/trace-viewer/issues/1161

I reported it on Chromium code review, but thought it was cross-posting it here.

https://code.google.com/p/chromium/issues/detail?id=515720

catapult-bot commented 9 years ago

Comment by yuhao Friday Jul 31, 2015 at 00:04 GMT

@natduca

catapult-bot commented 9 years ago

Comment by yuhao Monday Aug 03, 2015 at 17:38 GMT

A few more investigations.

  1. There is always only one repeated ID, with the name "TaskQueueManager::PostTask".
  2. The repeated ID is used as the "s" phase (flow producer).
  3. For those "f" phase flows that do not have a matching "s" phase, seems like they should have been matched by the repeated ID.
catapult-bot commented 9 years ago

Comment by natduca Tuesday Aug 04, 2015 at 00:17 GMT

Did reverting the patch that @skyostil mentioned help?

yuhao commented 9 years ago

This patch (https://codereview.chromium.org/1259583006/) fixed the uniqueness issue of PostTask. But the IPC flow IDs are still not unique (#1199).