search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 563 forks source link

Overhaul RecordingSelectionDialog #1943

Open natduca opened 8 years ago

natduca commented 8 years ago

It is a monstrosity, old and creaky. This is a tracking bug to do better. Old bugs will get duped into this.

nedn commented 8 years ago

What to do about this? I would love to contribute to learn more about tracing UI if there are guidances.

anniesullie commented 8 years ago

I think the big place to start is to figure out how the ideal RecordSelectionDialog would work. What would the default be? The presets? How would it remember your selections from previous usages? How would it list the tracing categories? Run through the existing bugs (hopefully all referencing this one) to think about how it would solve those problems, like robustness to import failures. Generate a doc about that, and start working backward to what the code should look like.

I think that the code should just be rewritten from scratch. Probably as a polymer 1.0 element after the CL to upgrade is landed.

@natduca do you agree? Should we schedule a sync to get on the same page?

natduca commented 8 years ago

Mmmm Ned, if you were interested in doing this as a free-time project, i'd be happy to chat with you and teach you a bit. My theory is that we want to write a ground-up new version of this in steps on trunk, and then swap in the new implementation once its good enough.

natduca commented 8 years ago

From our discussion, some good simple steps:

Once we have that, we can arrange that into a better tr-ui-trace-config-view in tracing/ui/. The binding of that to a dialog can be done by the embedder, which is record_and_capture_controller.html

petrcermak commented 8 years ago

Any updates on this? There is a feature request for a "dump memory" button in chrome://tracing which is blocked on #2013, which is in turn blocked on this.

nedn commented 8 years ago

Sorry, I was delay working on this to wait for the polymer conversion. I will resume my work on this.