lean config is broken - Githubissues

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.93k stars 563 forks source link

lean config is broken #2247

Open dvyukov opened 8 years ago

dvyukov commented 8 years ago

./tracing/bin/vulcanize_trace_viewer --config=lean on commit 623a005a3ffa9de13c4b92bc72290e7bcd1ca591 produces html that crashes with: trace:42 Uncaught TypeError: tr.importer.Import is not a constructor I've tried to add <link rel="import" href="/tracing/importer/import.html">, but it does not help. html starts importing but then displays blank screen.

hyangah commented 6 years ago

The following will make the lean config back to work but the size of output is not much smaller than the full config output. (1.8M vs 2.3M)

add in tracing/tracing/extras/lean_config.html

<link rel="import" href="/tracing/importer/import.html">

add in tracing/tracing/ui/extras/lean_config.html

<link rel="import" href="/tracing/ui/base/ui.html"> <link rel="import" href="/tracing/ui/timeline_view.html">