Open petrcermak opened 8 years ago
@dave-2 here is another bug at the intersection of perf dashboard and bisect. The trace urls are in the chartjson; I think we could send those from bisect->perf dashboard in the call to /post_bisect_results
. Picking the best trace for the common case where the summary metric is bisected will likely be tricksy, maybe @eakuefner has advice?
Couldn't we just always send all relevant traces? E.g. if you bisect a value that's an aggregate of pages pA, pB and do 2 repeats, then I think (links to) traces for all of pA1, pA2, pB1, pB2 should be provided.
I think this is already fixed? I have seen the option to download the traces.
I think the option to view the trace is only available via perf-try jobs. Bisect jobs don't parse the output for the cloud links or surface them to the dashboard in any way.
When there's a memory regression and the bisect blames a patch, we want to know why the particular memory component regressed. Unless there's something obviously wrong with the CL, the only way to move forward is to analyze the traces before and after the blamed patch.
However, it is quite complicated to get the traces at the moment. For example, given bisect results (https://bugs.chromium.org/p/chromium/issues/detail?id=633182#c17), you have to do the following:
@@@STEP_LOG_LINE@Captured Output@View generated trace files online at https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/trace-file-id_0-2016-08-08_16-15-21-69363.html for page https://www.facebook.com/rihanna@@@
).To sum up:
As a result, this adds a lot of unnecessary work for sheriffs.
Is there any way this could be automated? Ideally, the bisect would include links to the traces when it updates the bug. Alternatively, the bot could have a dedicated step that just lists links to the traces for each of the tested revisions and post a link to this step when it updates the bug (alongside "Buildbot stdio" and "Job details").
@anniesullie @ro-berto