Mismatch between series name in legend and chart

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.93k stars 564 forks source link

Mismatch between series name in legend and chart #2701

Closed perezju closed 8 years ago

perezju commented 8 years ago

See screenshot:

bad_dashboard

Not sure if this is just a display issue, or if values from different series have been actually jumbled up. :worried:

@anniesullie

perezju commented 8 years ago

I wanted to share a direct link to the dashboard showing the issue, but I've just noted that, copying the url and pasting on a new window does show the correct series on both legend and chart. So does look like some display issue only.

To reproduce:

Go to some dashboard with many subtests: example
Click to expand list of subtests on legend (e.g. "21 more")
Deselect the summary series (e.g. "foreground")
Select some random series (e.g. "http_m_facebook_com_rihanna")
Dashboard will often show the wrong series on the chart (e.g. "https_mobile_twitter_com_justinbieber_skip_interstitial_true")
Copy the url and paste onto new tab; both chart and legend show the correct series (e.g. "http_m_facebook_com_rihanna").

petrcermak commented 8 years ago

This is actually a duplicate of #2694, but since you added the extra details, I'll close the other issue instead :wink:

pavolas commented 8 years ago

If someone who works on this project hadn't told me about this bug, I would have lost many, many hours to it. This has comparable effect to the perf dashboard reporting wrong data. Seems like a P-0 to me. Can we please get this fixed ASAP?

anniesullie commented 8 years ago

@natduca I think you just hit this as well in #2742.

Apeliotes commented 8 years ago

I'll look at this today.

Apeliotes commented 8 years ago

So, it wasn't an issue with how we were displaying it. Turns out that we rely on the legend index matching that of the related json data. I'm reverting a cl that landed 3 weeks ago that alphabetized the legend and writing a new bug on us doing this in a less automagical way.

Apeliotes commented 8 years ago

New bug: #2747

Apeliotes commented 8 years ago

New version of Dashboard has been deployed and set as default. Please re-open if you can still see this behavior.