search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Handle irrelevant output lines in DeviceUtils.GetApplicationPaths #2952

Open jbudorick opened 8 years ago

jbudorick commented 8 years ago

When calling adb shell pm path <package>, we can get lines that don't start with package: that we don't care about, e.g. when adb isn't running beforehand

* daemon not running. starting it now on port 5037 *
* daemon started successfully *
package:/data/app/com.google.android.apps.chrome-1/base.apk

This currently will raise a CommandFailedError. It should instead ignore the lines it doesn't care about and only raise an error if it can't determine the path from the output.

jbudorick commented 8 years ago

additional context: https://bugs.chromium.org/p/chromium/issues/detail?id=656713#c17

jbudorick commented 8 years ago

actually, case, you can take this if you'd like, but I'm otherwise going to give it to hzl