search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 563 forks source link

Should CSS in <style> tags be indented? #3247

Open benshayden opened 7 years ago

benshayden commented 7 years ago

Most style tags in tracing/ currently do not indent their CSS.

There are 107 style tags in tracing/ui/. Only 19 of them indent: memorydump*, base/chart_*, plus a few scattered files like metrics_debugger_app and base/table.html.

There are 10 style tags in value/ui/. The only one that indents is in histogram_set_view.

There may be a readability argument to be made for indenting, but I feel that blank lines after the close tag address that concern.

Thoughts? @chromy @eakuefner @zeptonaut @lpy

Anybody know of any way to automatically enforce unindented CSS?

zeptonaut commented 7 years ago

I don't have too strong of an opinion here. Given that most of it is already unindented, I'd say to just make that the standard and change the nonconformant code.