catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Profiling files/cloud_urls should be associated with runs #3477

Open perezju opened 7 years ago

perezju commented 7 years ago

The page PageTestResults object currently associates profiling files/cloud_urls with pages (i.e. stories), but to better make sense of these they should be associated with individual story runs instead.

@nedn

nedn commented 7 years ago

@perezju Unless this is a one-line fix, I think we should hold off on fixing this at least until @ashley3 integrate Telemetry with flakiness dashboard? That project would open a bunch of new possibilities for surfacing Telemetry's failures, which may change the way we think about this.

perezju commented 7 years ago

Ah, somehow I missed that this work was already assigned to @ashley3 , and I had started writing an output formatter for JSON Test Results Format.

I'll send out my CL to both of you to review, even if it's discarded and superseded by Ashley's work, I hope it will help to kick off the discussion on how to implement some of the features we'll want.