Tracing has low usability on touch screen devices.

catapult-bot commented 9 years ago

Issue by natduca Monday Sep 22, 2014 at 20:14 GMT Originally opened as https://github.com/google/trace-viewer/issues/348

From dsinclair@chromium.org on July 29, 2013 13:45:14

Currently, touch doesn't work very well in trace-viewer. We should start enabling some touch handlers.

Things I've noticed:

Drag bar is not touch dragable.
Pan/scan, zoom and measurement modes do not do anything with touch (you just scroll the screen).
Modal window closing [x] does not work.
Can not drag the modal selector.
frame-viewer camera controls do not allow tilt or pan. Just scroll up/down.

Original issue: http://code.google.com/p/trace-viewer/issues/detail?id=343

catapult-bot commented 9 years ago

Comment by natduca Monday Sep 22, 2014 at 20:14 GMT

From dsinclair@chromium.org on July 08, 2014 12:34:29

Status: Assigned
Owner: tdres...@chromium.org

catapult-bot commented 9 years ago

Comment by natduca Monday Sep 22, 2014 at 20:14 GMT

From tdres...@chromium.org on July 09, 2014 06:34:16

I made the timeline view work with panning and zooming.

There's a fair bit of remaining work to be done in order to fully enable touch.

I'm fine with this being parked on me, but I doubt I'll get to the other features any time soon.

Cc: dsinclair@chromium.org

catapult-bot commented 9 years ago

Comment by natduca Monday Sep 22, 2014 at 20:14 GMT

From nd...@chromium.org on August 01, 2014 17:49:15

Should we mark fixed?

catapult-bot commented 9 years ago

Comment by natduca Monday Sep 22, 2014 at 20:14 GMT

From tdres...@chromium.org on August 05, 2014 06:01:12

I implemented a small subset of the functionality Dan mentioned in the bug description.

If we do want the other functionality, then we should probably leave this bug open. If we're happy with the way things are now, closing sounds good to me.

Personally, I don't value the other functionality enough to bother implementing it.

dj2 commented 9 years ago

The main points we need to work on soon-ish are:

Vertical Scrolling doesn't work at all.
Everything is tiny, and zooming with pinch-to-zoom doesn't work.
Most selection tools don't work.

bokand commented 9 years ago

I'll take this issue on as 20% time, can someone assign it to me? I assume I can't since I'm not a contributor/member? Not too familiar with the GitHub workflow yet...

anniesullie commented 9 years ago

I added you to the project and assigned you to this bug.

Note that we've just gotten hardware for Android buildbots; we'll be setting them up over the next two weeks. If you think it would help to have some tests on the CQ/waterfall, check with @dave-2 but note that we'll need to figure out how to automate them, which might be hard.

bokand commented 9 years ago

Thanks Annie!

bokand commented 9 years ago

Ok, playing around with this here's how I see the touch support in trace-viewer:

Overall, it seems a lot of the things mentioned earlier actually work now:

Vertical scrolling works (unless I misunderstood where)
Selection (by tapping) works, though there's no way to select a range or multiple items
As Dan mentioned, everything is tiny. Pinch-zoom scales the time axis (as I'd expect) so we can't use that to scale up. Ctrl+ page zoom makes things better though, maybe we should bump the page zoom is the pointer:coarse media query is false.

Here's what I found still lacking:

Selecting a time range is impossible
Can't resize the bottom "information" panel
Panning doesn't have fling/momentum behavior
Pinch-zoom can be used to scale the whole page when performed anywhere outside the timeline view. This can lead to the user getting stuck in one area
Can't spatially navigate (i.e. keyboard left/right). This could make it hard to select instant events
Can't drag the mode selector (is this what Nat referred to as "drag bar"?). If we can make time range selection possible (e.g. by dragging or tapping on the ruler, perhaps we can get rid of the selector altogether for touch only devices?)
Too easy to close the "shelf" when trying to select items in the timeline
Can't manipulate the frame-viewer (rotate, pan, etc). (What Nat calls "frame-viewer" is for e.g. the snapshots of cc::Picture/cc::LayerTreeHostImpl where you can see the drawn contents of the page, right?)

I'll start working through this list, feel free to chime in if there's other things y'all have noticed.

catapult-project / catapult

Tracing has low usability on touch screen devices. #348