search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Link to dashboard/report from results.html #3588

Open benshayden opened 7 years ago

benshayden commented 7 years ago

Currently, if users want to see the dashboard timeseries that corresponds to a row in results.html, they need to copy-paste the fields from TelemetryInfo into the test-picker. The dashboard's database can help put results in historical context, so it should be easier to get to the timeseries from results.html. This might look like a button in the histogram-set-table-name-cell. It would have to look sufficiently different from the current overview line chart icon somehow. Maybe a scroll would convey the sense of historicity?

anniesullie commented 7 years ago

How would we pick the bot to show from the perf dashboard?

Maybe show one of the material design icons? https://materialdesignicons.com/icon/history https://materialdesignicons.com/icon/timeline

benshayden commented 7 years ago

I thought we were going to surface results.html from buildbot? If so, those files should already have BuildbotInfo.

For results.html from run_benchmark, they should eventually have DeviceInfo, so the dashboard could find a bot that was most similar to what that DeviceInfo says.

As a fallback, the report page could fill in as much of the test path as it can and wait for the user to select the missing pieces manually.

Does that sound right?

anniesullie commented 7 years ago

Maybe we could start with just having the link if there's a BuildBotInfo?

benshayden commented 7 years ago

Ping from @agrieve