Remove compare_samples once recipe bisect is turned down

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..

https://chromium.googlesource.com/catapult

BSD 3-Clause "New" or "Revised" License

1.93k stars 563 forks source link

Remove compare_samples once recipe bisect is turned down #3768

Open benshayden opened 7 years ago

benshayden commented 7 years ago

Currently, compare_samples supports HistogramSets alongside chart-json and builbot output. However, neither bisect nor perf try bots ever pass HistogramSets to compare_samples, and they never will because they are being deprecated in favor of pinpoint. @eakuefner @simonhatch

simonhatch commented 7 years ago

We can probably just remove compare_samples when we remove the bisect recipe.

eakuefner commented 7 years ago

@benshayden has removed HistogramSet support from compare_samples so that we don't have to worry about it when doing refactorings, but probably, cleaning up this script is still a good idea. Renaming and reassigning to @simonhatch.