catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 562 forks source link

Results pages should show commit positions, not git hashes #4196

Open pcc opened 6 years ago

pcc commented 6 years ago
  1. Go to https://pinpoint-dot-chromeperf.appspot.com/results2/107dd144840000
  2. Try to figure out whether each column is from before or after my change

== Expected behaviour ==

It should be easy to figure out which headers are before and which are after. Ideally each header should provide a commit position i.e. chromium@531079, chromium@531026 etc instead of a hash. It might also be nice to provide some other indicator (such as colour coding) to easily determine before/after.

== Actual behaviour ==

I end up having to copy each hash (manually, because the page prevents copying the header columns) into a local command line to figure out what the commit position is and compare it against the commit position of my change.

simonhatch commented 6 years ago

@dave-2

dave-2 commented 6 years ago

Since you're looking for your own change, do you think it would be useful to show the author of the commit instead?

pcc commented 6 years ago

Couple of problems that I see with that:

dave-2 commented 6 years ago

That's true, the commit positions are useful for getting a sense of the ordering. I can change it to commit positions.

One note about autorolls: Pinpoint automatically expands DEPS rolls, and some dependent repos don't have commit positions, so you'd still see the git hash for those.