catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Some rows not being created #4329

Closed eakuefner closed 6 years ago

eakuefner commented 6 years ago

ChromiumPerfFyi/histogram-diff-histograms-11/memory.long_running_idle_gmail_background_tbmv2 / v8_compile_full_code_cpu_self_sum /https___mail.google.commail is also present in chart JSON and is 0. So we would expect to see this in the histogram pipeline as a 0-valued, 0-error row, but @simonhatch confirms that we have a TestMetadata entity but not a matching row.

eakuefner commented 6 years ago

Offline discussion with @simonhatch reveals that this is not a bug. We bail out of proceeding if a histogram is empty. All empty histograms trivially have count 0 and sum 0.