search

catapult-project / catapult

Deprecated Catapult GitHub. Please instead use http://crbug.com "Speed>Benchmarks" component for bugs and https://chromium.googlesource.com/catapult for downloading and editing source code..
https://chromium.googlesource.com/catapult
BSD 3-Clause "New" or "Revised" License
1.93k stars 564 forks source link

Trace viewer: Non top-level render processes (e.g. OOPIFs, extensions) need better names #4366

Open csharrison opened 6 years ago

csharrison commented 6 years ago

Now that site isolation is rolling out, this is critical to help understand control flow when viewing traces.

Ideally, we could have subframes be labeled with their origins / URLs, along with a pointer to the PID of their parent.

fmeawad commented 6 years ago

I would argue that it is a crbug not a catapult bug, since we are currently not adding the correct process information in C++.

I hacked something briefly when I was looking at some traces, I will clean it and land it soon.

csharrison commented 6 years ago

Sorry, I am not 100% sure where the logic is. Happy to close this in favor of crbug if you prefer.

fmeawad commented 6 years ago

I will take care of it as I am landing the code.